WiFiEasyConnect - TeamThinkpalm: Easy Connect application #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Added required implementations for the Easy Connect Application to work. Test Procedure: Build should be successful. Risks: None Signed-off-by:[email protected]
|
|
Nikita-Hakai
pushed a commit
to Nikita-Hakai/OneWifi
that referenced
this pull request
Oct 28, 2025
…ed till further update. (rdkcentral#359) * Reason for change: 1) Fixed all the warnings observed with werror flag in controller makefiles. 2) Fixed runtime error for valid value for type 'em_profile_type_t', observed after enabling werror. 3) Keeping werror disable in makefile till further update. Test Procedure: Compared the run time logs for OneWifi, controller and agent with and without changes and did not observed any additional logs/error. Tested the changes by changing the SSID, Passphrase and radio channel through CLI observed its works fine. Risks: Medium Priority: P1 Signed-off-by: prashant-singh1 <[email protected]> * Reason for change: 1) Handled review comments. 2) Resolved few new warnings related to unused parameter and typecasting Test Procedure: Compared the run time logs for OneWifi, controller and agent with and without changes and did not observed any additional logs/error. Tested the changes by changing the SSID, Passphrase and radio channel through CLI observed its works fine. Risks: Medium Priority: P1 Signed-off-by: prashant-singh1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Added required implementations for the Easy Connect Application to work. Test Procedure: Build should be successful.
Risks: None
Signed-off-by:[email protected]